Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVA 🌠 #104

Merged
merged 1 commit into from
Sep 17, 2015
Merged

AVA 🌠 #104

merged 1 commit into from
Sep 17, 2015

Conversation

floatdrop
Copy link
Contributor

Migration from tape to AVA.

  • Tests runs successfully
  • Fix body in GET test on NodeJS 0.10

@arthurvr
Copy link

Yippeee! Nice work.

@sindresorhus
Copy link
Owner

Yay!

Use ES2015 in tests (maybe after avajs/ava#50)

Nah, don't have to wait for that. Tests will only be a tiny bit slower to start.

sindresorhus
sindresorhus reviewed Sep 17, 2015
View reviewed changes
test/test-arguments.js
@@ -35,23 +35,23 @@ test('url argument is required', function (t) {
});
});

test('accepts url.parse object as first argument', function (t) {
test('arguments - accepts url.parse object as first argument', function (t) {
got({hostname: s.host, port: s.port, path: '/test'}, function (err, data) {
t.error(err);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.error => t.ifError

@sindresorhus
Copy link
Owner

Fix body in GET test on NodeJS 0.10

Maybe try running it as test.serial. Might be some kind of race issue.

floatdrop added a commit that referenced this pull request Sep 17, 2015
@floatdrop
Merge pull request #104 from sindresorhus/ava
20f2792 
AVA 🌠
@floatdrop floatdrop merged commit 20f2792 into master Sep 17, 2015
@floatdrop floatdrop deleted the ava branch September 17, 2015 12:20
@floatdrop
Copy link
Contributor Author

Boom 💥

@sindresorhus
Copy link
Owner

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floatdrop @arthurvr @sindresorhus